MINOR: Test Coverage for Segmented stores#21860
Open
eduwercamacaro wants to merge 8 commits intoapache:trunkfrom
Open
MINOR: Test Coverage for Segmented stores#21860eduwercamacaro wants to merge 8 commits intoapache:trunkfrom
eduwercamacaro wants to merge 8 commits intoapache:trunkfrom
Conversation
github-actions
bot
added
triage
bbejeck
approved these changes
Mar 30, 2026
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Thanks for the follow-up @eduwercamacaro - LGTM with a couple of minor nits
| */ | ||
| private static final Comparator<byte[]> BYTES_COMPARATOR = Arrays::compare; | ||
|
|
||
|
|
| import static org.mockito.Mockito.verify; | ||
| import static org.mockito.Mockito.when; | ||
| import static org.mockito.Mockito.mock; | ||
|
|
...src/test/java/org/apache/kafka/streams/state/internals/AbstractColumnFamilyAccessorTest.java
Outdated
Show resolved
Hide resolved
…/AbstractColumnFamilyAccessorTest.java Co-authored-by: Bill Bejeck <bbejeck@gmail.com>
Contributor
Author
|
@bbejeck Thanks for reviewing. Suggestions applied now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR for KAFKA-19713 that includes test cases for:
offsetsColumnFamilyThis PR also refactors AbstractColumnFamily tests to not use a mock by
creating an in-memory version of a RocksDBAccessor.
Reviewers: Bill Bejeck bbejeck@apache.org